Skip to content

VR: fix haproxy check when ssl offloading is configured #12596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
weizhouapache wants to merge 1 commit into
base: 4.22
Choose a base branch
from
Draft

VR: fix haproxy check when ssl offloading is configured #12596

weizhouapache wants to merge 1 commit into from
+1 −1

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Feb 5, 2026

Description

This PR fixes #12591

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:virtual-router Python Warning... Python code Ahead! labels Feb 5, 2026
@codecov
Copy link

codecov bot commented Feb 5, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.62%. Comparing base (30d3066) to head (fc1cc74).
⚠️ Report is 1 commits behind head on 4.22.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.22   #12596   +/-   ##
=========================================
  Coverage     17.62%   17.62%           
- Complexity    15664    15665    +1     
=========================================
  Files          5915     5915           
  Lines        531144   531171   +27     
  Branches      64930    64938    +8     
=========================================
+ Hits          93591    93608   +17     
- Misses       427015   427023    +8     
- Partials      10538    10540    +2
Flag Coverage Δ
uitests 3.71% <ø> (-0.01%) ⬇️
unittests 18.69% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland added this to the 4.22.1 milestone Feb 5, 2026
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Feb 5, 2026

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 5, 2026

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Feb 5, 2026

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 16713

@weizhouapache
Copy link
Member Author

weizhouapache commented Feb 5, 2026

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 5, 2026

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Feb 5, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16715

@weizhouapache
Copy link
Member Author

weizhouapache commented Feb 5, 2026

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Feb 5, 2026

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Feb 6, 2026

[SF] Trillian test result (tid-15403)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53144 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12596-t15403-kvm-ol8.zip
Smoke tests completed. 146 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestListIdsParams>:teardown Error 1.17 test_list_ids_parameter.py
test_01_snapshot_root_disk Error 4.01 test_snapshots.py
test_02_list_snapshots_with_removed_data_store Error 46.94 test_snapshots.py
test_02_list_snapshots_with_removed_data_store Error 46.94 test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown Error 27.66 test_snapshots.py
test_01_snapshot_usage Error 48.28 test_usage.py
test_01_vpn_usage Error 1.10 test_usage.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:virtual-router Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.22.1

Development

Successfully merging this pull request may close these issues.

3 participants

@weizhouapache @DaanHoogland @blueorangutan